🤖 fix: wait for successful template builds before promotion#70
Conversation
|
@codex review Please review this PR for correctness and readiness. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc356f5170
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed feedback about preserving API error mapping for template build wait failures/timeouts. |
|
@codex review |
Add configurable template-version build wait/backoff for aggregated codertemplate updates. Export a reusable aggregated CoderTemplate example and document tuning knobs.
Preserve Kubernetes API error mapping for template build failures/timeouts during active-version promotion.
ThomasK33
force-pushed
the
k8s-operator-sa3j
branch
from
31b2fca to
b462966
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4629664eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fd9b30999
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address Codex review by aligning aggregated API request timeout defaults with template build waits and preserving timeout/cancel semantics when mapping build wait errors. - set aggregated API request timeout default to 30m - distinguish internal build wait expiry from request lifecycle cancellation/deadline - keep internal wait expiry as BadRequest while returning Timeout for canceled/deadline contexts - add coverage for request-timeout mapping and config defaults - document request-timeout relationship in aggregated deployment guide --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.57`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.57 -->
ThomasK33
force-pushed
the
k8s-operator-sa3j
branch
from
3fd9b30 to
63db29c
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Fix aggregated CoderTemplate update behavior so new template versions are promoted to active only after the build succeeds, and export a reusable aggregated template example for smoke/regression testing.
Background
Template updates were creating new Coder template versions, but promotion could race the provisioner build and fail with a "running build" error. That left active version unchanged, which matched the issue observed during testing.
Implementation
Validation
Risks
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.00